lkml.org 
[lkml]   [2021]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [RFC 3/3] gpiolib: coldfire: remove custom asm/gpio.h
    On Fri, Nov 5, 2021 at 2:05 PM Arnd Bergmann <arnd@kernel.org> wrote:

    > From: Arnd Bergmann <arnd@arndb.de>
    >
    > Now that coldfire is the only user of a custom asm/gpio.h, it seems
    > better to remove this as well, and have the same interface everywhere.
    >
    > For the gpio_get_value()/gpio_set_value()/gpio_to_irq(), gpio_cansleep()
    > functions, the custom version is only a micro-optimization to inline the
    > function for constant GPIO numbers. However, in the coldfire defconfigs,
    > I was unable to find a single instance where this micro-optimization
    > was even used, so to my best knowledge removing this has no downsides.
    >
    > The custom gpio_request_one() function is even less useful, as it is
    > guarded by an #ifdef that is never true.
    >
    > Signed-off-by: Arnd Bergmann <arnd@arndb.de>

    Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

    Yours,
    Linus Walleij

    \
     
     \ /
      Last update: 2021-11-09 21:09    [W:2.463 / U:0.368 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site