Messages in this thread | | | Date | Tue, 9 Nov 2021 19:56:07 +0100 | From | Peter Zijlstra <> | Subject | Re: [RFC PATCH 4/7] static_call: fix broken static_call_query() for non-exported keys |
| |
On Tue, Nov 09, 2021 at 05:45:46PM +0100, Ard Biesheuvel wrote: > static_call_query() accesses the func member of the static call key > directly, which means that it is broken for cases where it is used from > a module and the key resides elsewhere and is not exported. >
Arguably when the module can't change the value, it shouldn't be having any interest in obtaining said value either.
I really think you're exporting too much. Modules aren't good, they deserve to suffer.
| |