Messages in this thread | | | Subject | Re: [PATCH] f2fs: provide a way to attach HIPRI for Direct IO | From | Jens Axboe <> | Date | Tue, 9 Nov 2021 09:42:18 -0700 |
| |
On 11/9/21 9:39 AM, Christoph Hellwig wrote: > On Mon, Nov 08, 2021 at 06:13:36PM -0800, Jaegeuk Kim wrote: >> This patch adds a way to attach HIPRI by expanding the existing sysfs's >> data_io_flag. User can measure IO performance by enabling it. > > NAK. This flag should only be used when explicitly specified by > the submitter of the I/O.
Yes, this cannot be set in the middle for a multitude of reasons. I wonder if we should add a comment to that effect near the definition of it.
-- Jens Axboe
| |