Messages in this thread | | | Date | Tue, 9 Nov 2021 15:09:21 +0300 | Subject | Re: [PATCH] staging: r8188eu: remove unneeded variable | From | Pavel Skripkin <> |
| |
On 11/9/21 14:53, cgel.zte@gmail.com wrote: > From: Changcheng Deng <deng.changcheng@zte.com.cn> > > Fix the following coccicheck review: > ./drivers/staging/r8188eu/core/rtw_cmd.c: 66: 5-8: Unneeded variable > > Remove unneeded variable used to store return value. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn> > --- > drivers/staging/r8188eu/core/rtw_cmd.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188eu/core/rtw_cmd.c > index e17332677daa..1b1c47f4a34e 100644 > --- a/drivers/staging/r8188eu/core/rtw_cmd.c > +++ b/drivers/staging/r8188eu/core/rtw_cmd.c > @@ -62,8 +62,6 @@ static void c2h_wk_callback(struct work_struct *work); > > static int _rtw_init_evt_priv(struct evt_priv *pevtpriv) > { > - int res = _SUCCESS; > - > /* allocate DMA-able/Non-Page memory for cmd_buf and rsp_buf */ > atomic_set(&pevtpriv->event_seq, 0); > pevtpriv->evt_done_cnt = 0; > @@ -72,7 +70,7 @@ static int _rtw_init_evt_priv(struct evt_priv *pevtpriv) > pevtpriv->c2h_wk_alive = false; > pevtpriv->c2h_queue = rtw_cbuf_alloc(C2H_QUEUE_MAX_LEN + 1); > > - return res; > + return _SUCCESS; > } >
Shouldn't it return just void then?
With regards, Pavel Skripkin
| |