Messages in this thread | | | Date | Tue, 9 Nov 2021 12:15:11 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH v2] sched/core: forced idle accounting |
| |
On Mon, Oct 18, 2021 at 01:34:28PM -0700, Josh Don wrote: > @@ -5804,6 +5830,12 @@ pick_next_task(struct rq *rq, struct task_struct *prev, struct rq_flags *rf) > } > } > > + if (rq->core->core_forceidle_count) {
Does this want to be something like:
if (schedstat_enabled() && .. ) ?
afaict without schedstat on this is dead code.
> + if (cookie) > + rq->core->core_forceidle_start = rq_clock(rq->core); > + rq->core->core_forceidle_occupation = occ; > + } > + > rq->core->core_pick_seq = rq->core->core_task_seq; > next = rq->core_pick; > rq->core_sched_seq = rq->core->core_pick_seq;
| |