Messages in this thread | | | From | Linus Walleij <> | Date | Tue, 9 Nov 2021 12:08:25 +0100 | Subject | Re: [PATCH] pinctrl: qcom: sdm845: Enable dual edge errata |
| |
On Tue, Nov 2, 2021 at 4:41 AM Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
> It has been observed that dual edge triggered wakeirq GPIOs on SDM845 > doesn't trigger interrupts on the falling edge. > > Enabling wakeirq_dual_edge_errata for SDM845 indicates that the PDC in > SDM845 suffers from the same problem described, and worked around, by > Doug in 'c3c0c2e18d94 ("pinctrl: qcom: Handle broken/missing PDC dual > edge IRQs on sc7180")', so enable the workaround for SDM845 as well. > > The specific problem seen without this is that gpio-keys does not detect > the falling edge of the LID gpio on the Lenovo Yoga C630 and as such > consistently reports the LID as closed. > > Fixes: e35a6ae0eb3a ("pinctrl/msm: Setup GPIO chip in hierarchy") > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Patch applied for fixes!
Yours, Linus Walleij
| |