Messages in this thread | | | From | Vladimir Oltean <> | Subject | Re: [PATCH net] net: stmmac: allow a tc-taprio base-time of zero | Date | Tue, 9 Nov 2021 10:35:05 +0000 |
| |
On Tue, Nov 09, 2021 at 09:20:53AM +0100, Kurt Kanzenbach wrote: > Hi Vladimir, > > On Mon Nov 08 2021, Vladimir Oltean wrote: > > Commit fe28c53ed71d ("net: stmmac: fix taprio configuration when > > base_time is in the past") allowed some base time values in the past, > > but apparently not all, the base-time value of 0 (Jan 1st 1970) is still > > explicitly denied by the driver. > > > > Remove the bogus check. > > > > Fixes: b60189e0392f ("net: stmmac: Integrate EST with TAPRIO scheduler API") > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> > > I've experienced the same problem and wanted to send a patch for > it. Thanks! > > Reviewed-by: Kurt Kanzenbach <kurt@linutronix.de>
Cool. So you had that patch queued up? What other stmmac patches do you have queued up? :) Do you have a fix for the driver setting the PTP time every time when SIOCSHWTSTAMP is called? This breaks the UTC-to-TAI offset established by phc2sys and it takes a few seconds to readjust, which is very annoying.
| |