| From | Geert Uytterhoeven <> | Date | Tue, 9 Nov 2021 09:39:33 +0100 | Subject | Re: [PATCH 07/13] dt-bindings: rtc: add bindings for microchip mpfs rtc |
| |
Hi Conor,
On Mon, Nov 8, 2021 at 4:07 PM <conor.dooley@microchip.com> wrote: > From: Conor Dooley <conor.dooley@microchip.com> > > Add device tree bindings for the real time clock on > the Microchip PolarFire SoC. > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > Signed-off-by: Daire McNamara <daire.mcnamara@microchip.com>
Thanks for your patch!
> --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/microchip,mfps-rtc.yaml > @@ -0,0 +1,61 @@
> +examples: > + - | > + #include <dt-bindings/clock/microchip,mpfs-clock.h> > + soc { > + #address-cells = <2>; > + #size-cells = <2>;
Examples are indeed built with #{address,size}-cells = <1>. However, there is no need to override this. Just drop the zeros in the reg property below.
> + rtc@20124000 { > + compatible = "microchip,mpfs-rtc"; > + reg = <0 0x20124000 0 0x1000>; > + clocks = <&clkcfg CLK_RTC>; > + clock-names = "rtc"; > + interrupts = <80>; > + }; > + }; > +...
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
|