lkml.org 
[lkml]   [2021]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.14 63/75] RDMA/core: Use kvzalloc when allocating the struct ib_port
    Date
    From: wangyugui <wangyugui@e16-tech.com>

    [ Upstream commit 911a81c9c7092bfd75432ce79b2ef879127ea065 ]

    The 'struct attribute' flex array contains some struct lock_class_key's
    which become big when lockdep is turned on. Big enough that some drivers
    will not load when CONFIG_PROVE_LOCKING=y because they cannot allocate
    enough memory:

    WARNING: CPU: 36 PID: 8 at mm/page_alloc.c:5350 __alloc_pages+0x27e/0x3e0
    Call Trace:
    kmalloc_order+0x2a/0xb0
    kmalloc_order_trace+0x19/0xf0
    __kmalloc+0x231/0x270
    ib_setup_port_attrs+0xd8/0x870 [ib_core]
    ib_register_device+0x419/0x4e0 [ib_core]
    bnxt_re_task+0x208/0x2d0 [bnxt_re]

    Link: https://lore.kernel.org/r/20211019002656.17745-1-wangyugui@e16-tech.com
    Signed-off-by: wangyugui <wangyugui@e16-tech.com>
    Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/infiniband/core/sysfs.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sysfs.c
    index 6146c3c1cbe5c..8d709986b88c7 100644
    --- a/drivers/infiniband/core/sysfs.c
    +++ b/drivers/infiniband/core/sysfs.c
    @@ -757,7 +757,7 @@ static void ib_port_release(struct kobject *kobj)
    if (port->hw_stats_data)
    kfree(port->hw_stats_data->stats);
    kfree(port->hw_stats_data);
    - kfree(port);
    + kvfree(port);
    }

    static void ib_port_gid_attr_release(struct kobject *kobj)
    @@ -1189,7 +1189,7 @@ static struct ib_port *setup_port(struct ib_core_device *coredev, int port_num,
    struct ib_port *p;
    int ret;

    - p = kzalloc(struct_size(p, attrs_list,
    + p = kvzalloc(struct_size(p, attrs_list,
    attr->gid_tbl_len + attr->pkey_tbl_len),
    GFP_KERNEL);
    if (!p)
    --
    2.33.0
    \
     
     \ /
      Last update: 2021-11-09 23:30    [W:4.134 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site