lkml.org 
[lkml]   [2021]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.14 13/75] scsi: lpfc: Fix list_add() corruption in lpfc_drain_txq()
    Date
    From: James Smart <jsmart2021@gmail.com>

    [ Upstream commit 99154581b05c8fb22607afb7c3d66c1bace6aa5d ]

    When parsing the txq list in lpfc_drain_txq(), the driver attempts to pass
    the requests to the adapter. If such an attempt fails, a local "fail_msg"
    string is set and a log message output. The job is then added to a
    completions list for cancellation.

    Processing of any further jobs from the txq list continues, but since
    "fail_msg" remains set, jobs are added to the completions list regardless
    of whether a wqe was passed to the adapter. If successfully added to
    txcmplq, jobs are added to both lists resulting in list corruption.

    Fix by clearing the fail_msg string after adding a job to the completions
    list. This stops the subsequent jobs from being added to the completions
    list unless they had an appropriate failure.

    Link: https://lore.kernel.org/r/20210910233159.115896-2-jsmart2021@gmail.com
    Co-developed-by: Justin Tee <justin.tee@broadcom.com>
    Signed-off-by: Justin Tee <justin.tee@broadcom.com>
    Signed-off-by: James Smart <jsmart2021@gmail.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/lpfc/lpfc_sli.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
    index f530d8fe7a8ce..260e09b8ba38d 100644
    --- a/drivers/scsi/lpfc/lpfc_sli.c
    +++ b/drivers/scsi/lpfc/lpfc_sli.c
    @@ -20357,6 +20357,7 @@ lpfc_drain_txq(struct lpfc_hba *phba)
    fail_msg,
    piocbq->iotag, piocbq->sli4_xritag);
    list_add_tail(&piocbq->list, &completions);
    + fail_msg = NULL;
    }
    spin_unlock_irqrestore(&pring->ring_lock, iflags);
    }
    --
    2.33.0
    \
     
     \ /
      Last update: 2021-11-09 23:24    [W:4.177 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site