lkml.org 
[lkml]   [2021]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 09/10] user_events: Optimize writing events by only copying data once
On Mon, 8 Nov 2021 15:17:10 -0800
Beau Belgrave <beaub@linux.microsoft.com> wrote:

> > Which reminds me that trace_event_buffer_reserve() expects to be called
> > with preemption disabled. And I'm guessing that may not be the case for you.
> >
>
> Thanks, should be good there:
> I have rcu_read_lock_sched() held, which will have preemption disabled
> during the various probe calls.

Ah, that's right. Thanks for the reminder.

>
> > I'll change this so that it always disables preemption even if it uses the
> > filter buffer, and *always* disables preemption on return.

Even so, I think it's better to have it consistently disable/enable
preemption than expect the caller to do so.

-- Steve

\
 
 \ /
  Last update: 2021-11-09 00:20    [W:0.148 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site