Messages in this thread | | | From | Brad Larson <> | Date | Mon, 8 Nov 2021 11:02:05 -0800 | Subject | Re: [PATCH v3 11/11] arm64: dts: Add Pensando Elba SoC support |
| |
Hi Mark,
On Mon, Nov 8, 2021 at 2:26 AM Mark Rutland <mark.rutland@arm.com> wrote: > > No; as above, you should *not* use GIC_CPU_MASK_SIMPLE() at all for GICv3. i.e. > > > timer { > > compatible = "arm,armv8-timer"; > > interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_LOW>, > > <GIC_PPI 14 IRQ_TYPE_LEVEL_LOW>, > > <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>, > > <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>; > > }; > > Please see the GICv3 binding documentation: > > Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml > > ... and note that it does not have the cpumask field as use by the binding for > prior generations of GIC: > > Documentation/devicetree/bindings/interrupt-controller/arm,gic.yaml > > > If you've seen other dts files using GIC_CPU_MASK_SIMPLE() with GICv3, those > are incorrect, and need to be fixed. > > Thanks, > Mark.
I'll use the bindings documentation as the primary reference. The use of GIC_CPU_MASK_SIMPLE() is removed and tests ok. These arm64 dts files in linux-next are gic-v3 and use GIC_CPU_MASK_SIMPLE(1, 2, 4, 8)
./nvidia/tegra234.dtsi ./renesas/r9a07g044.dtsi ./renesas/r8a779a0.dtsi ./qcom/sm8350.dtsi ./qcom/sm8250.dtsi ./freescale/fsl-ls1028a.dtsi ./freescale/imx8mp.dtsi ./freescale/imx8mn.dtsi ./freescale/imx8mm.dtsi
Thanks, Brad
| |