Messages in this thread | | | Date | Mon, 8 Nov 2021 13:51:23 +0100 | Subject | Re: [PATCH v2 3/7] arm64: dts: qcom: sdm660-xiaomi-lavender: Add volume down button | From | Konrad Dybcio <> |
| |
On 08/11/2021 06:03, Dang Huynh wrote: > This enables the volume down key. > > Reviewed-by: Caleb Connolly <caleb@connolly.tech> > Reviewed-by: Martin Botka <martin.botka@somainline.org> > Signed-off-by: Dang Huynh <danct12@riseup.net> > --- > arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts b/arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts > index 365a03b56cde..28408240735b 100644 > --- a/arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts > +++ b/arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts > @@ -51,6 +51,16 @@ &blsp1_uart2 { > status = "okay"; > }; > > +&pon { > + voldown { > + compatible = "qcom,pm8941-resin"; > + interrupts = <0x0 0x8 1 IRQ_TYPE_EDGE_BOTH>; > + debounce = <15625>; > + bias-pull-up; > + linux,code = <KEY_VOLUMEDOWN>; > + }; > +}; Could you commonize the RESIN instead, like in here [1]?
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/arm64/boot/dts/qcom?h=v5.15&id=b135d097eb1a2586ee2c0ebcc0d0aa4a9b641b68
Konrad
| |