lkml.org 
[lkml]   [2021]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v1 10/19] pinctrl: armada-37xx: Make use of the devm_platform_ioremap_resource()
Date
Hello Andy,

> Use the devm_platform_ioremap_resource() helper instead of
> calling of_address_to_resource() and devm_ioremap_resource()
> separately.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Gregory CLEMENT <gregory.clement@bootlin.com>

Thanks,

Gregory

> ---
> drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
> index 37f92dc54d7a..282b3fac3bec 100644
> --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
> +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
> @@ -727,7 +727,6 @@ static int armada_37xx_irqchip_register(struct platform_device *pdev,
> struct gpio_irq_chip *girq = &gc->irq;
> struct device *dev = &pdev->dev;
> struct device_node *np;
> - struct resource res;
> int ret = -ENODEV, i, nr_irq_parent;
>
> /* Check if we have at least one gpio-controller child node */
> @@ -750,12 +749,7 @@ static int armada_37xx_irqchip_register(struct platform_device *pdev,
> return 0;
> }
>
> - if (of_address_to_resource(dev->of_node, 1, &res)) {
> - dev_err(dev, "cannot find IO resource\n");
> - return -ENOENT;
> - }
> -
> - info->base = devm_ioremap_resource(dev, &res);
> + info->base = devm_platform_ioremap_resource(pdev, 1);
> if (IS_ERR(info->base))
> return PTR_ERR(info->base);
>
> --
> 2.33.0
>

--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

\
 
 \ /
  Last update: 2021-11-08 11:56    [W:0.341 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site