lkml.org 
[lkml]   [2021]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v0 17/42] drivers: video: Check notifier registration return value
Date
From: Borislav Petkov <bp@suse.de>

Avoid homegrown notifier registration checks.

No functional changes.

Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: linux-fbdev@vger.kernel.org
Cc: linux-hyperv@vger.kernel.org
---
drivers/video/console/dummycon.c | 3 ++-
drivers/video/fbdev/hyperv_fb.c | 5 +++--
2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/video/console/dummycon.c b/drivers/video/console/dummycon.c
index f1711b2f9ff0..2d0cdd76dfde 100644
--- a/drivers/video/console/dummycon.c
+++ b/drivers/video/console/dummycon.c
@@ -36,7 +36,8 @@ void dummycon_register_output_notifier(struct notifier_block *nb)
{
WARN_CONSOLE_UNLOCKED();

- raw_notifier_chain_register(&dummycon_output_nh, nb);
+ if (raw_notifier_chain_register(&dummycon_output_nh, nb))
+ pr_warn("dummycon output notifier already registered\n");

if (dummycon_putc_called)
nb->notifier_call(nb, 0, NULL);
diff --git a/drivers/video/fbdev/hyperv_fb.c b/drivers/video/fbdev/hyperv_fb.c
index 23999df52739..183bd459e5c2 100644
--- a/drivers/video/fbdev/hyperv_fb.c
+++ b/drivers/video/fbdev/hyperv_fb.c
@@ -1255,8 +1255,9 @@ static int hvfb_probe(struct hv_device *hdev,

par->synchronous_fb = false;
par->hvfb_panic_nb.notifier_call = hvfb_on_panic;
- atomic_notifier_chain_register(&panic_notifier_list,
- &par->hvfb_panic_nb);
+
+ if (atomic_notifier_chain_register(&panic_notifier_list, &par->hvfb_panic_nb))
+ pr_warn("Hyper-V FB panic notifier already registered\n");

return 0;

--
2.29.2
\
 
 \ /
  Last update: 2021-11-08 11:15    [W:0.248 / U:0.792 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site