lkml.org 
[lkml]   [2021]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/3] KVM: x86: Copy kvm_pmu_ops by value to eliminate layer of indirection
From
On 5/11/2021 11:36 pm, Sean Christopherson wrote:
> On Fri, Nov 05, 2021, Sean Christopherson wrote:
>> On Wed, Nov 03, 2021, Like Xu wrote:
>> I would also say land this memcpy() above kvm_ops_static_call_update(), then the
>> enabling patch can do the static call updates in kvm_ops_static_call_update()
>> instead of adding another helper.
>
> Ugh, kvm_ops_static_call_update() is defined in kvm_host.h. That's completely
> unnecessary, it should have exactly one caller, kvm_arch_hardware_setup(). As a
> prep match, move kvm_ops_static_call_update() to x86.c, then it can reference the
> pmu ops.

Quite good and thank you.


\
 
 \ /
  Last update: 2021-11-08 10:26    [W:0.047 / U:2.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site