Messages in this thread | | | From | Andy Shevchenko <> | Date | Mon, 8 Nov 2021 10:36:33 +0200 | Subject | Re: [PATCH v4] tty: vt: keyboard: add default switch-case, to handle smatch-warnings in method vt_do_kdgkb_ioctl |
| |
On Sun, Nov 7, 2021 at 4:10 PM Ajay Garg <ajaygargnsit@gmail.com> wrote: > > smatch-kchecker gives the following warnings when run on keyboard.c : > > vt_do_kdgkb_ioctl() error: uninitialized symbol 'kbs'. > vt_do_kdgkb_ioctl() error: uninitialized symbol 'ret'. > > This usually happens when switch has no default case and static > analyzers and even sometimes compilers can’t prove that all possible > values are covered. > >
One blank line is enough.
> Thus, the default switch-case has been added, which sets the values > for the two variables : > > * kbs as NULL, which also nicely fits in with kfree. > > * ret as -ENOIOCTLCMD (on same lines if there is no cmd > match in "vt_do_kdskled" method). > > > Many thanks to the following for review of previous versions : > > * Pavel Skripkin <paskripkin@gmail.com> > * Andy Shevchenko <andy.shevchenko@gmail.com> > >
Ditto for each such case.
...
> + default: > + kbs = NULL;
> + ret = -ENOIOCTLCMD;
Why is this? How is it supposed to work?
> + break; > }
-- With Best Regards, Andy Shevchenko
| |