Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Mon, 8 Nov 2021 09:24:24 +0100 | Subject | Re: [RFC 3/3] gpiolib: coldfire: remove custom asm/gpio.h |
| |
Hi Arnd,
On Fri, Nov 5, 2021 at 2:05 PM Arnd Bergmann <arnd@kernel.org> wrote: > From: Arnd Bergmann <arnd@arndb.de> > > Now that coldfire is the only user of a custom asm/gpio.h, it seems > better to remove this as well, and have the same interface everywhere. > > For the gpio_get_value()/gpio_set_value()/gpio_to_irq(), gpio_cansleep() > functions, the custom version is only a micro-optimization to inline the > function for constant GPIO numbers. However, in the coldfire defconfigs, > I was unable to find a single instance where this micro-optimization > was even used, so to my best knowledge removing this has no downsides.
The only user seems to be QSPI chip select handling (not bit-banged data transfer) in arch/m68k/coldfire/device.c, but that indeed depends on CONFIG_SPI_COLDFIRE_QSPI, which is not set in any of the defconfigs. That doesn't mean there were/are no real users, though ;-)
> The custom gpio_request_one() function is even less useful, as it is > guarded by an #ifdef that is never true. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |