Messages in this thread | | | From | "Fabio M. De Francesco" <> | Subject | Re: [PATCH v3] staging: r8188eu: Use kzalloc() with GFP_ATOMIC in atomic context | Date | Sun, 07 Nov 2021 12:43:51 +0100 |
| |
On Monday, November 1, 2021 8:18:47 PM CET Fabio M. De Francesco wrote: > Use the GFP_ATOMIC flag of kzalloc() with two memory allocation in > report_del_sta_event(). This function is called while holding spinlocks, > therefore it is not allowed to sleep. With the GFP_ATOMIC type flag, the > allocation is high priority and must not sleep. > > This issue is detected by Smatch which emits the following warning: > "drivers/staging/r8188eu/core/rtw_mlme_ext.c:6848 report_del_sta_event() > warn: sleeping in atomic context". > > After the change, the post-commit hook output the following message: > "CHECK: Prefer kzalloc(sizeof(*pcmd_obj)...) over > kzalloc(sizeof(struct cmd_obj)...)". > > According to the above "CHECK", use the preferred style in the first > kzalloc(). > > Fixes: 79f712ea994d ("staging: r8188eu: Remove wrappers for kalloc() and kzalloc()") > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com> > --- > > v2->v3: Add the "Fixes:" tag, as requested by Greg Kroah-Hartman. > > v1->v2: Fix an error that I introduced with an incorrect copy-paste > of the sizeof() operator. > > drivers/staging/r8188eu/core/rtw_mlme_ext.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
Hello Greg,
I've noticed that you have already applied recent changes to drivers/staging up to the patches of November 6th, but my patch is not among them.
This patch has already been acked by Larry and I'm not sure if I should send a v4 with his "Acked-by" tag or if you can add it by yourself when applying to your tree.
Please let me know if there is something that prevents this patch to be applied. I have no problem in changing / adding whatever it is needed.
Thanks,
Fabio M. De Francesco
| |