Messages in this thread | | | From | Ilya Dryomov <> | Date | Mon, 8 Nov 2021 04:46:40 +0100 | Subject | Re: [PATCH v2 1/2] ceph: libceph: move ceph_osdc_copy_from() into cephfs code |
| |
On Thu, Nov 4, 2021 at 1:31 PM Luís Henriques <lhenriques@suse.de> wrote: > > This patch moves ceph_osdc_copy_from() function out of libceph code into > cephfs. There are no other users for this function, and there is the need > (in another patch) to access internal ceph_osd_request struct members. > Thus, instead of changing ceph_osdc_copy_from() to return the request, > simply move it where it is needed.
Hi Luis,
ceph_alloc_copyfrom_request() does exactly that -- returns the request. I have dropped this sentence from the changelog but wanted to check if you meant to keep the change instead of just moving and renaming.
Thanks,
Ilya
| |