Messages in this thread | | | Date | Sun, 7 Nov 2021 21:48:38 +0100 | Subject | Re: [PATCH 4/4] bq25890_charger: Enable continuous conversion for ADC at charging | From | Hans de Goede <> |
| |
Hi,
On 11/7/21 21:20, Yauhen Kharuzhy wrote: > Instead of one shot run of ADC at beginning of charging, run continuous > conversion to ensure that all charging-related values are monitored > properly (input voltage, input current, themperature etc.). > > Signed-off-by: Yauhen Kharuzhy <jekhor@gmail.com>
Thank you for finding this! This explains why all the ADC returned values like current_now where 0 when charging, I thought this was just something which was only supported while not charging, heh.
As before, the patch subject prefix should be: "power: supply: bq25890: "
Otherwise the patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Sebastian, this really is a pure bug-fix patch, any chance you can pick this up for a future 5.16-rc# pull-req ?
Regards,
Hans
> --- > drivers/power/supply/bq25890_charger.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/power/supply/bq25890_charger.c b/drivers/power/supply/bq25890_charger.c > index fb2f1578503c..26ac7cde8c02 100644 > --- a/drivers/power/supply/bq25890_charger.c > +++ b/drivers/power/supply/bq25890_charger.c > @@ -609,12 +609,12 @@ static irqreturn_t __bq25890_handle_irq(struct bq25890_device *bq) > > if (!new_state.online && bq->state.online) { /* power removed */ > /* disable ADC */ > - ret = bq25890_field_write(bq, F_CONV_START, 0); > + ret = bq25890_field_write(bq, F_CONV_RATE, 0); > if (ret < 0) > goto error; > } else if (new_state.online && !bq->state.online) { /* power inserted */ > /* enable ADC, to have control of charge current/voltage */ > - ret = bq25890_field_write(bq, F_CONV_START, 1); > + ret = bq25890_field_write(bq, F_CONV_RATE, 1); > if (ret < 0) > goto error; > } >
| |