Messages in this thread | | | Date | Sun, 7 Nov 2021 21:29:13 +0100 | Subject | Re: [PATCH 1/4] bq25890_charger: Rename IILIM field to IINLIM | From | Hans de Goede <> |
| |
Hi,
On 11/7/21 21:19, Yauhen Kharuzhy wrote: > Rename the Input Current Limit field in the REG00 from IILIM to IINLIM > accordingly with the bq2589x datasheet. This is just cosmetical change > to reduce confusion. > > Signed-off-by: Yauhen Kharuzhy <jekhor@gmail.com>
Thank you, this typo was annoying me too :)
Patch subject prefix should be: "power: supply: bq25890: "
Otherwise this looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> --- > drivers/power/supply/bq25890_charger.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/power/supply/bq25890_charger.c b/drivers/power/supply/bq25890_charger.c > index 34ec186a2e9a..34467bfb9537 100644 > --- a/drivers/power/supply/bq25890_charger.c > +++ b/drivers/power/supply/bq25890_charger.c > @@ -40,7 +40,7 @@ static const char *const bq25890_chip_name[] = { > }; > > enum bq25890_fields { > - F_EN_HIZ, F_EN_ILIM, F_IILIM, /* Reg00 */ > + F_EN_HIZ, F_EN_ILIM, F_IINLIM, /* Reg00 */ > F_BHOT, F_BCOLD, F_VINDPM_OFS, /* Reg01 */ > F_CONV_START, F_CONV_RATE, F_BOOSTF, F_ICO_EN, > F_HVDCP_EN, F_MAXC_EN, F_FORCE_DPM, F_AUTO_DPDM_EN, /* Reg02 */ > @@ -153,7 +153,7 @@ static const struct reg_field bq25890_reg_fields[] = { > /* REG00 */ > [F_EN_HIZ] = REG_FIELD(0x00, 7, 7), > [F_EN_ILIM] = REG_FIELD(0x00, 6, 6), > - [F_IILIM] = REG_FIELD(0x00, 0, 5), > + [F_IINLIM] = REG_FIELD(0x00, 0, 5), > /* REG01 */ > [F_BHOT] = REG_FIELD(0x01, 6, 7), > [F_BCOLD] = REG_FIELD(0x01, 5, 5), > @@ -256,7 +256,7 @@ enum bq25890_table_ids { > /* range tables */ > TBL_ICHG, > TBL_ITERM, > - TBL_IILIM, > + TBL_IINLIM, > TBL_VREG, > TBL_BOOSTV, > TBL_SYSVMIN, > @@ -299,7 +299,7 @@ static const union { > /* TODO: BQ25896 has max ICHG 3008 mA */ > [TBL_ICHG] = { .rt = {0, 5056000, 64000} }, /* uA */ > [TBL_ITERM] = { .rt = {64000, 1024000, 64000} }, /* uA */ > - [TBL_IILIM] = { .rt = {100000, 3250000, 50000} }, /* uA */ > + [TBL_IINLIM] = { .rt = {100000, 3250000, 50000} }, /* uA */ > [TBL_VREG] = { .rt = {3840000, 4608000, 16000} }, /* uV */ > [TBL_BOOSTV] = { .rt = {4550000, 5510000, 64000} }, /* uV */ > [TBL_SYSVMIN] = { .rt = {3000000, 3700000, 100000} }, /* uV */ > @@ -503,11 +503,11 @@ static int bq25890_power_supply_get_property(struct power_supply *psy, > break; > > case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT: > - ret = bq25890_field_read(bq, F_IILIM); > + ret = bq25890_field_read(bq, F_IINLIM); > if (ret < 0) > return ret; > > - val->intval = bq25890_find_val(ret, TBL_IILIM); > + val->intval = bq25890_find_val(ret, TBL_IINLIM); > break; > > case POWER_SUPPLY_PROP_VOLTAGE_NOW: >
| |