lkml.org 
[lkml]   [2021]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH] scsi: snic: Replace snprintf in show functions with sysfs_emit
From
Date
On Fri, 2021-11-05 at 08:14 +0000, cgel.zte@gmail.com wrote:
> From: Jing Yao <yao.jing2@zte.com.cn>
>
> coccicheck complains about the use of snprintf() in sysfs show
> functions:
> WARNING use scnprintf or sprintf
>
> Use sysfs_emit instead of scnprintf, snprintf or sprintf makes more
> sense.
[]
> diff --git a/drivers/scsi/snic/snic_attrs.c b/drivers/scsi/snic/snic_attrs.c
[]
> @@ -37,7 +37,7 @@ snic_show_state(struct device *dev,
> {
> struct snic *snic = shost_priv(class_to_shost(dev));
>
> - return snprintf(buf, PAGE_SIZE, "%s\n",
> + return sysfs_emit(buf, "%s\n",
> snic_state_str[snic_get_state(snic)]);
> }

when you do these, please consider the ability to rewrap to 80 columns.

return sysfs_emit(buf, "%s\n", snic_state_str[snic_get_state(snic)]);

> @@ -59,7 +59,7 @@ snic_show_link_state(struct device *dev,
> if (snic->config.xpt_type == SNIC_DAS)
> snic->link_status = svnic_dev_link_status(snic->vdev);
>
> - return snprintf(buf, PAGE_SIZE, "%s\n",
> + return sysfs_emit(buf, "%s\n",
> (snic->link_status) ? "Link Up" : "Link Down");

And maintain parenthesis alignment

return sysfs_emit(buf, "%s\n",
snic->link_status ? "Link Up" : "Link Down");

or maybe

return sysfs_emit(buf, "Link %s\n", snic->link_status ? "Up" : "Down");

\
 
 \ /
  Last update: 2021-11-07 17:13    [W:0.033 / U:1.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site