Messages in this thread | | | Date | Sat, 6 Nov 2021 10:50:24 -0500 | From | Bjorn Andersson <> | Subject | Re: [PATCH] thermal/drivers/qcom/spmi-adc-tm5: Remove unnecessary print function dev_err() |
| |
On Thu 04 Nov 20:33 CDT 2021, Xu Wang wrote:
> The print function dev_err() is redundant because > platform_get_irq() already prints an error. > > Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> --- > drivers/thermal/qcom/qcom-spmi-adc-tm5.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c > index 824671cf494a..8492dd3bfed6 100644 > --- a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c > +++ b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c > @@ -612,10 +612,8 @@ static int adc_tm5_probe(struct platform_device *pdev) > adc_tm->base = reg; > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - dev_err(dev, "get_irq failed: %d\n", irq); > + if (irq < 0) > return irq; > - } > > ret = adc_tm5_get_dt_data(adc_tm, node); > if (ret) { > -- > 2.25.1 >
| |