Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [PATCH 4/4] intel_idle: Add SPR support with AMX INIT-state | Date | Fri, 05 Nov 2021 18:26:27 +0100 |
| |
On Fri, Nov 05 2021 at 16:03, Bae, Chang Seok wrote: > On Nov 5, 2021, at 07:33, Thomas Gleixner <tglx@linutronix.de> wrote: >> On Thu, Nov 04 2021 at 15:52, Chang S. Bae wrote: >>> +static __cpuidle int intel_idle_tile(struct cpuidle_device *dev, >>> + struct cpuidle_driver *drv, int index) >>> +{ >>> + fpu_idle_fpregs(); >> >> That's redundant because arch_cpu_idle_enter() is invoked before the >> actual idle mechanism. > > I think the way this series is shaped makes confusion, sorry. > > Since PATCH3 and PATCH4 are in debate -- which approach should be chosen, it > was decided to post both and let just one of them be selected. E.g., if PATCH3 > is right, then PATCH4 should be abandoned.
My bad. I should have read the cover letter before complaining.
> I think PATCH3 is better. Maybe PATCH4 should not be sent together to avoid > such confusion.
Yes. patch 3 is way better than patch 4.
Thanks,
tglx
| |