Messages in this thread | | | From | "Bae, Chang Seok" <> | Subject | Re: [PATCH 4/4] intel_idle: Add SPR support with AMX INIT-state | Date | Fri, 5 Nov 2021 16:03:56 +0000 |
| |
On Nov 5, 2021, at 07:33, Thomas Gleixner <tglx@linutronix.de> wrote: > > Chang, > > On Thu, Nov 04 2021 at 15:52, Chang S. Bae wrote: >> +/** >> + * intel_idle_tile - Ask the processor to enter the given idle state. >> + * @dev: cpuidle device of the target CPU. >> + * @drv: cpuidle driver (assumed to point to intel_idle_driver). >> + * >> + * Ensure TILE registers in INIT-state before using intel_idle() to >> + * enter the idle state. >> + */ >> +static __cpuidle int intel_idle_tile(struct cpuidle_device *dev, >> + struct cpuidle_driver *drv, int index) >> +{ >> + fpu_idle_fpregs(); > > That's redundant because arch_cpu_idle_enter() is invoked before the > actual idle mechanism.
I think the way this series is shaped makes confusion, sorry.
Since PATCH3 and PATCH4 are in debate -- which approach should be chosen, it was decided to post both and let just one of them be selected. E.g., if PATCH3 is right, then PATCH4 should be abandoned.
I think PATCH3 is better. Maybe PATCH4 should not be sent together to avoid such confusion.
Thanks, Chang
| |