lkml.org 
[lkml]   [2021]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5.10 13/16] ARM: 9120/1: Revert "amba: make use of -1 IRQs warn"
Hi!

> From: Wang Kefeng <wangkefeng.wang@huawei.com>
>
> commit eb4f756915875b0ea0757751cd29841f0504d547 upstream.
>
> After commit 77a7300abad7 ("of/irq: Get rid of NO_IRQ usage"),
> no irq case has been removed, irq_of_parse_and_map() will return
> 0 in all cases when get error from parse and map an interrupt into
> linux virq space.
>
> amba_device_register() is only used on no-DT initialization, see
> s3c64xx_pl080_init() arch/arm/mach-s3c/pl080.c
> ep93xx_init_devices() arch/arm/mach-ep93xx/core.c
>
> They won't set -1 to irq[0], so no need the warn.

AFAICT this does not fix any bug. It is simply a WARN that can not
trigger.

Best regards,
Pavel

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-11-05 14:33    [W:0.106 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site