Messages in this thread | | | Date | Fri, 5 Nov 2021 14:32:43 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH 5.10 13/16] ARM: 9120/1: Revert "amba: make use of -1 IRQs warn" |
| |
Hi!
> From: Wang Kefeng <wangkefeng.wang@huawei.com> > > commit eb4f756915875b0ea0757751cd29841f0504d547 upstream. > > After commit 77a7300abad7 ("of/irq: Get rid of NO_IRQ usage"), > no irq case has been removed, irq_of_parse_and_map() will return > 0 in all cases when get error from parse and map an interrupt into > linux virq space. > > amba_device_register() is only used on no-DT initialization, see > s3c64xx_pl080_init() arch/arm/mach-s3c/pl080.c > ep93xx_init_devices() arch/arm/mach-ep93xx/core.c > > They won't set -1 to irq[0], so no need the warn.
AFAICT this does not fix any bug. It is simply a WARN that can not trigger.
Best regards, Pavel
-- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany [unhandled content-type:application/pgp-signature] | |