Messages in this thread | | | From | David Laight <> | Subject | RE: [PATCH v2] um: use swap() to make code cleaner | Date | Fri, 5 Nov 2021 11:30:40 +0000 |
| |
From: Yang Guang > Sent: 05 November 2021 06:19 > > Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid > opencoding it.
Is there any real point to any of these patches??
If I'm reading a 'random' piece of code I now have to assume that swap() is something that 'magically' exchanges two items. This requires more brain-power than parsing the three lines that do an actual swap.
David
- Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
| |