lkml.org 
[lkml]   [2021]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2 2/2] drm: Move nomodeset kernel parameter to the DRM subsystem
    From
    On 11/5/21 10:00, Thomas Zimmermann wrote:

    [snip]

    >> +
    >> +static int __init disable_modeset(char *str)
    >> +{
    >> + drm_nomodeset = true;
    >> +
    >> + pr_warn("You have booted with nomodeset. This means your GPU drivers are DISABLED\n");
    >> + pr_warn("Any video related functionality will be severely degraded, and you may not even be able to suspend the system properly\n");
    >> + pr_warn("Unless you actually understand what nomodeset does, you should reboot without enabling it\n");
    >
    > I'd update this text to be less sensational.
    >

    This is indeed quite sensational. But think we can do it as a follow-up patch.

    Since we will have to stick with nomodeset for backward compatibility, I was
    planning to add documentation to explain what this parameter is about and what
    is the actual effect of setting it.

    So I think we can change this as a part of that patch-set.

    >> +
    >> + return 1;
    >> +}
    >> +
    >> +/* Disable kernel modesetting */
    >> +__setup("nomodeset", disable_modeset);
    >> diff --git a/drivers/gpu/drm/i915/i915_module.c b/drivers/gpu/drm/i915/i915_module.c
    >> index 45cb3e540eff..c890c1ca20c4 100644
    >> --- a/drivers/gpu/drm/i915/i915_module.c
    >> +++ b/drivers/gpu/drm/i915/i915_module.c
    >> @@ -4,8 +4,6 @@
    >> * Copyright © 2021 Intel Corporation
    >> */
    >>
    >> -#include <linux/console.h>
    >> -
    >
    > These changes should be in patch 1?
    >

    Yes, I forgot to move these when changed the order of the patches.

    Best regards, --
    Javier Martinez Canillas
    Linux Engineering
    Red Hat

    \
     
     \ /
      Last update: 2021-11-05 10:56    [W:3.044 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site