lkml.org 
[lkml]   [2021]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH net-next v4] net: marvell: prestera: add firmware v4.0 support
Date
> 
> > From: Volodymyr Mytnyk <vmytnyk@marvell.com>
> >
> > Add firmware (FW) version 4.0 support for Marvell Prestera
> > driver.
> >
> > Major changes have been made to new v4.0 FW ABI to add support
> > of new features, introduce the stability of the FW ABI and ensure
> > better forward compatibility for the future driver vesrions.
> >
> > Current v4.0 FW feature set support does not expect any changes
> > to ABI, as it was defined and tested through long period of time.
> > The ABI may be extended in case of new features, but it will not
> > break the backward compatibility.
> >
> > ABI major changes done in v4.0:
> > - L1 ABI, where MAC and PHY API configuration are split.
> > - ACL has been split to low-level TCAM and Counters ABI
> > to provide more HW ACL capabilities for future driver
> > versions.
> >
> > To support backward support, the addition compatibility layer is
> > required in the driver which will have two different codebase under
> > "if FW-VER elif FW-VER else" conditions that will be removed
> > in the future anyway, So, the idea was to break backward support
> > and focus on more stable FW instead of supporting old version
> > with very minimal and limited set of features/capabilities.
> >
> > Improve FW msg validation:
> > * Use __le64, __le32, __le16 types in msg to/from FW to
> > catch endian mismatch by sparse.
> > * Use BUILD_BUG_ON for structures sent/recv to/from FW.
> >
> > Co-developed-by: Vadym Kochan <vkochan@marvell.com>
> > Signed-off-by: Vadym Kochan <vkochan@marvell.com>
> > Signed-off-by: Yevhen Orlov <yevhen.orlov@plvision.eu>
> > Signed-off-by: Taras Chornyi <tchornyi@marvell.com>
> > Signed-off-by: Volodymyr Mytnyk <vmytnyk@marvell.com>
>
> Compiling this file on m68k results in:
>
> In file included from <command-line>:
> In function 'prestera_hw_build_tests',
> inlined from 'prestera_hw_switch_init' at drivers/net/ethernet/marvell/prestera/prestera_hw.c:788:2:
> include/linux/compiler_types.h:317:45: error: call to '__compiletime_assert_351' declared with attribute error: BUILD_BUG_ON failed: sizeof(struct prestera_msg_switch_attr_req) != 16
>
> The size of struct prestera_msg_switch_attr_req is not well defined.
>
> struct prestera_msg_switch_attr_req {
> struct prestera_msg_cmd cmd; // 4 bytes
> __le32 attr; // 4 bytes
> union prestera_msg_switch_param param; // 6 bytes
> };
>
> The compiler may well decide, in this situation, to generate a structure of
> size 14, not 16. The error is therefore not surprising.

Hi Guenter,

This commit has been merged w/o waiting for all review comments to be addressed for some reason. So, there is other commits that fix this problem.

1. [PATCH] [-next] net: marvell: prestera: Add explicit padding (merged already)
https://www.spinics.net/lists/kernel/msg4132698.html

2. [PATCH net v3] net: marvell: prestera: fix hw structure laid out (not merged yet, still need to address the comments and new patch v4 to be uploaded)
https://www.spinics.net/lists/kernel/msg4132698.html

>
> Guenter

Volodymyr

\
 
 \ /
  Last update: 2021-11-05 09:37    [W:0.409 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site