Messages in this thread | | | Date | Thu, 4 Nov 2021 17:53:54 +0100 | From | Greg KH <> | Subject | Re: [stable 5.10 PATCH] mm: hwpoison: remove the unnecessary THP check |
| |
On Wed, Nov 03, 2021 at 10:46:24AM +0100, Greg KH wrote: > On Mon, Nov 01, 2021 at 12:48:56PM -0700, Yang Shi wrote: > > commit c7cb42e94473aafe553c0f2a3d8ca904599399ed upstream. > > > > When handling THP hwpoison checked if the THP is in allocation or free > > stage since hwpoison may mistreat it as hugetlb page. After commit > > 415c64c1453a ("mm/memory-failure: split thp earlier in memory error > > handling") the problem has been fixed, so this check is no longer > > needed. Remove it. The side effect of the removal is hwpoison may > > report unsplit THP instead of unknown error for shmem THP. It seems not > > like a big deal. > > > > The following patch "mm: filemap: check if THP has hwpoisoned subpage > > for PMD page fault" depends on this, which fixes shmem THP with > > hwpoisoned subpage(s) are mapped PMD wrongly. So this patch needs to be > > backported to -stable as well. > > > > Link: https://lkml.kernel.org/r/20211020210755.23964-2-shy828301@gmail.com > > Signed-off-by: Yang Shi <shy828301@gmail.com> > > Suggested-by: Naoya Horiguchi <naoya.horiguchi@nec.com> > > Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com> > > Cc: Hugh Dickins <hughd@google.com> > > Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> > > Cc: Matthew Wilcox <willy@infradead.org> > > Cc: Oscar Salvador <osalvador@suse.de> > > Cc: Peter Xu <peterx@redhat.com> > > Cc: <stable@vger.kernel.org> > > Signed-off-by: Andrew Morton <akpm@linux-foundation.org> > > Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> > > --- > > mm-filemap-check-if-thp-has-hwpoisoned-subpage-for-pmd-page-fault.patch > > depends on this one. > > Both now queued up, thanks.
This breaks the build, see: https://lore.kernel.org/r/acabc414-164b-cd65-6a1a-cf912d8621d7@roeck-us.net
so I'm going to drop both of these now. Please fix this up and resend a tested series.
thanks,
greg k-h
| |