lkml.org 
[lkml]   [2021]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] tcp: Use BIT() for OPTION_* constants
Date
From: Eric Dumazet
> Sent: 03 November 2021 22:50
>
> On 11/3/21 3:17 PM, Leonard Crestez wrote:
> > Extending these flags using the existing (1 << x) pattern triggers
> > complaints from checkpatch. Instead of ignoring checkpatch modify the
> > existing values to use BIT(x) style in a separate commit.
> >
> > Signed-off-by: Leonard Crestez <cdleonard@gmail.com>
> >
>
> Yes, I guess checkpatch does not know that we currently use at most 16 bits :)
>
> u16 options = opts->options;
>
> Anyway, this seems fine.

Doesn't BIT() have a nasty habit of generating 64bit constants
that just cause a different set of issues when inverted?
It may be safe here - but who knows.

David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
\
 
 \ /
  Last update: 2021-11-04 10:19    [W:3.949 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site