lkml.org 
[lkml]   [2021]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.14 09/14] net: chelsio: cxgb4vf: Fix an error code in cxgb4vf_pci_probe()
    Date
    From: Zheyu Ma <zheyuma97@gmail.com>

    [ Upstream commit b82d71c0f84a2e5ccaaa7571dfd5c69e0e2cfb4a ]

    During the process of driver probing, probe function should return < 0
    for failure, otherwise kernel will treat value == 0 as success.

    Therefore, we should set err to -EINVAL when
    adapter->registered_device_map is NULL. Otherwise kernel will assume
    that driver has been successfully probed and will cause unexpected
    errors.

    Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
    index fa116f0a107db..8ebc0398de767 100644
    --- a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
    +++ b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
    @@ -3100,6 +3100,7 @@ static int cxgb4vf_pci_probe(struct pci_dev *pdev,
    }
    if (adapter->registered_device_map == 0) {
    dev_err(&pdev->dev, "could not register any net devices\n");
    + err = -EINVAL;
    goto err_disable_interrupts;
    }

    --
    2.33.0
    \
     
     \ /
      Last update: 2021-11-30 16:06    [W:4.533 / U:0.780 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site