lkml.org 
[lkml]   [2021]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] usb: typec: clear usb_pd flag if change to typec only mode
On Tue, Nov 30, 2021 at 10:57:13AM +0800, steven_syu wrote:
> This patch handle power mode change from PD to Type-C only
> and the user space unknown power delivery was turned off
> by typec driver.

I do not understand this sentance, can you please rewrite it a bit?

> Signed-off-by: steven_syu <steven_syu@asus.com>

Please use the name you sign documents with, I doubt you do so with a
"_" in it, right?

> ---
> drivers/usb/typec/class.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
> index aeef453..11e2a98 100644
> --- a/drivers/usb/typec/class.c
> +++ b/drivers/usb/typec/class.c
> @@ -1718,6 +1718,10 @@ void typec_set_pwr_opmode(struct typec_port *port,
> partner->usb_pd = 1;
> sysfs_notify(&partner_dev->kobj, NULL,
> "supports_usb_power_delivery");
> + } else if (opmode != TYPEC_PWR_MODE_PD && partner->usb_pd) {
> + partner->usb_pd = 0;
> + sysfs_notify(&partner_dev->kobj, NULL,
> + "supports_usb_power_delivery");

Are you sure this is correct? You set usb_pd to 0 and then told
userspace it was 1?

confused,

greg k-h

\
 
 \ /
  Last update: 2021-11-30 08:01    [W:0.077 / U:0.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site