lkml.org 
[lkml]   [2021]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.15 53/68] x86/boot: Mark prepare_command_line() __init
    Date
    From: Borislav Petkov <bp@suse.de>

    [ Upstream commit c0f2077baa4113f38f008b8e912b9fb3ff8d43df ]

    Fix:

    WARNING: modpost: vmlinux.o(.text.unlikely+0x64d0): Section mismatch in reference \
    from the function prepare_command_line() to the variable .init.data:command_line
    The function prepare_command_line() references
    the variable __initdata command_line.
    This is often because prepare_command_line lacks a __initdata
    annotation or the annotation of command_line is wrong.

    Apparently some toolchains do different inlining decisions.

    Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
    Signed-off-by: Borislav Petkov <bp@suse.de>
    Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
    Link: https://lkml.kernel.org/r/YZySgpmBcNNM2qca@zn.tnic
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/x86/kernel/setup.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
    index d71267081153f..ee055430a89f4 100644
    --- a/arch/x86/kernel/setup.c
    +++ b/arch/x86/kernel/setup.c
    @@ -742,7 +742,7 @@ dump_kernel_offset(struct notifier_block *self, unsigned long v, void *p)
    return 0;
    }

    -static char *prepare_command_line(void)
    +static char * __init prepare_command_line(void)
    {
    #ifdef CONFIG_CMDLINE_BOOL
    #ifdef CONFIG_CMDLINE_OVERRIDE
    --
    2.33.0
    \
     
     \ /
      Last update: 2021-11-30 15:54    [W:3.611 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site