lkml.org 
[lkml]   [2021]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.15 20/68] scsi: ufs: ufs-mediatek: Add put_device() after of_find_device_by_node()
    Date
    From: Ye Guojin <ye.guojin@zte.com.cn>

    [ Upstream commit cc03facb1c4248997592fc683518c00cc257db1a ]

    This was found by coccicheck:

    ./drivers/scsi/ufs/ufs-mediatek.c, 211, 1-7, ERROR missing put_device;
    call of_find_device_by_node on line 1185, but without a corresponding
    object release within this function.

    Link: https://lore.kernel.org/r/20211110105133.150171-1-ye.guojin@zte.com.cn
    Reported-by: Zeal Robot <zealci@zte.com.cn>
    Reviewed-by: Peter Wang <peter.wang@mediatek.com>
    Signed-off-by: Ye Guojin <ye.guojin@zte.com.cn>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/ufs/ufs-mediatek.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
    index 80b3545dd17d6..ecc503171db6b 100644
    --- a/drivers/scsi/ufs/ufs-mediatek.c
    +++ b/drivers/scsi/ufs/ufs-mediatek.c
    @@ -1102,6 +1102,7 @@ static int ufs_mtk_probe(struct platform_device *pdev)
    }
    link = device_link_add(dev, &reset_pdev->dev,
    DL_FLAG_AUTOPROBE_CONSUMER);
    + put_device(&reset_pdev->dev);
    if (!link) {
    dev_notice(dev, "add reset device_link fail\n");
    goto skip_reset;
    --
    2.33.0
    \
     
     \ /
      Last update: 2021-11-30 15:49    [W:6.012 / U:0.396 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site