lkml.org 
[lkml]   [2021]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] selftests/ftrace: make kprobe profile testcase description unique
On Tue, 30 Nov 2021 13:25:46 +0100
Heiko Carstens <hca@linux.ibm.com> wrote:

> Commit 32f6e5da83c7 ("selftests/ftrace: Add kprobe profile testcase")
> added a new kprobes testcase, but has a description which does not
> describe what the test case is doing and is duplicating the desription
> of another test case.
> Therefore change the test case description, so it is unique and then
> allows easily to tell which test case actually passed or failed.

Good catch!

This looks good to me.

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Thank you,

>
> Reported-by: Alexander Egorenkov <egorenar@linux.ibm.com>
> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
> ---
> tools/testing/selftests/ftrace/test.d/kprobe/profile.tc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/profile.tc b/tools/testing/selftests/ftrace/test.d/kprobe/profile.tc
> index 98166fa3eb91..34fb89b0c61f 100644
> --- a/tools/testing/selftests/ftrace/test.d/kprobe/profile.tc
> +++ b/tools/testing/selftests/ftrace/test.d/kprobe/profile.tc
> @@ -1,6 +1,6 @@
> #!/bin/sh
> # SPDX-License-Identifier: GPL-2.0
> -# description: Kprobe dynamic event - adding and removing
> +# description: Kprobe profile
> # requires: kprobe_events
>
> ! grep -q 'myevent' kprobe_profile
> --
> 2.32.0
>


--
Masami Hiramatsu <mhiramat@kernel.org>

\
 
 \ /
  Last update: 2021-11-30 15:18    [W:0.059 / U:1.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site