Messages in this thread | | | Subject | Re: [PATCH v2 1/3] block: simplify calling convention of elv_unregister_queue() | From | Hannes Reinecke <> | Date | Tue, 30 Nov 2021 07:44:48 +0100 |
| |
On 11/30/21 5:03 AM, Eric Biggers wrote: > From: Eric Biggers <ebiggers@google.com> > > Make elv_unregister_queue() a no-op if q->elevator is NULL or is not > registered. > > This simplifies the existing callers, as well as the future caller in > the error path of blk_register_queue(). > > Also don't bother checking whether q is NULL, since it never is. > > Signed-off-by: Eric Biggers <ebiggers@google.com> > --- > block/blk-sysfs.c | 3 +-- > block/elevator.c | 8 ++++---- > 2 files changed, 5 insertions(+), 6 deletions(-) > Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
| |