lkml.org 
[lkml]   [2021]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] misc: fastrpc: Add fdlist implementation
From
Date
Hi Jeya,

This is version 2 of the patchset which is not reflected in the subject
line.




On 30/11/2021 12:54, Jeya R wrote:
> Add fdlist implementation to support dma handles. fdlist is populated
> by DSP if any map is no longer used and it is freed during put_args.
>
> Signed-off-by: Jeya R <jeyr@codeaurora.org>
> ---
> drivers/misc/fastrpc.c | 22 ++++++++++++++++++++--
> 1 file changed, 20 insertions(+), 2 deletions(-)

Have you missed comments my comments on this patch

https://www.spinics.net/lists/linux-arm-msm/msg99023.html

--srini

>
> diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
> index 39aca77..3c937ff 100644
> --- a/drivers/misc/fastrpc.c
> +++ b/drivers/misc/fastrpc.c
> @@ -353,7 +353,7 @@ static void fastrpc_context_free(struct kref *ref)
> ctx = container_of(ref, struct fastrpc_invoke_ctx, refcount);
> cctx = ctx->cctx;
>
> - for (i = 0; i < ctx->nscalars; i++)
> + for (i = 0; i < ctx->nbufs; i++)
> fastrpc_map_put(ctx->maps[i]);
>
> if (ctx->buf)
> @@ -785,6 +785,7 @@ static int fastrpc_get_args(u32 kernel, struct fastrpc_invoke_ctx *ctx)
> err = fastrpc_buf_alloc(ctx->fl, dev, pkt_size, &ctx->buf);
> if (err)
> return err;
> + memset(ctx->buf->virt, 0, pkt_size);
>
> rpra = ctx->buf->virt;
> list = ctx->buf->virt + ctx->nscalars * sizeof(*rpra);
> @@ -887,9 +888,19 @@ static int fastrpc_put_args(struct fastrpc_invoke_ctx *ctx,
> u32 kernel)
> {
> struct fastrpc_remote_arg *rpra = ctx->rpra;
> - int i, inbufs;
> + struct fastrpc_map *mmap = NULL;
> + struct fastrpc_invoke_buf *list;
> + struct fastrpc_phy_page *pages;
> + u64 *fdlist;
> + int i, inbufs, outbufs, handles;
>
> inbufs = REMOTE_SCALARS_INBUFS(ctx->sc);
> + outbufs = REMOTE_SCALARS_OUTBUFS(ctx->sc);
> + handles = REMOTE_SCALARS_INHANDLES(ctx->sc) + REMOTE_SCALARS_OUTHANDLES(ctx->sc);
> + list = ctx->buf->virt + ctx->nscalars * sizeof(*rpra);
> + pages = ctx->buf->virt + ctx->nscalars * (sizeof(*list) +
> + sizeof(*rpra));
> + fdlist = (uint64_t *)(pages + inbufs + outbufs + handles);
>
> for (i = inbufs; i < ctx->nbufs; ++i) {
> if (!ctx->maps[i]) {
> @@ -906,6 +917,13 @@ static int fastrpc_put_args(struct fastrpc_invoke_ctx *ctx,
> }
> }
>
> + for (i = 0; i < FASTRPC_MAX_FDLIST; i++) {
> + if (!fdlist[i])
> + break;
> + if (!fastrpc_map_find(fl, (int)fdlist[i], &mmap))
> + fastrpc_map_put(mmap);
> + }
> +
> return 0;
> }
>
>

\
 
 \ /
  Last update: 2021-11-30 14:13    [W:0.088 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site