lkml.org 
[lkml]   [2021]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] ASoC: Intel: atom: Remove redundant check to simplify the code
On Fri, Nov 26, 2021 at 2:37 PM Tang Bin <tangbin@cmss.chinamobile.com> wrote:
>
> In the function sst_platform_get_resources(), if platform_get_irq()
> failed, the return should not be zero, as the example in
> platform.c is
> * int irq = platform_get_irq(pdev, 0)
> * if (irq < 0)
> * return irq;
> So remove the redundant check to simplify the code.

FWIW,
Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>

Code is correct, I haven't checked the rest, though.

> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---
> sound/soc/intel/atom/sst/sst_acpi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/intel/atom/sst/sst_acpi.c b/sound/soc/intel/atom/sst/sst_acpi.c
> index 3be64430c..696d547c5 100644
> --- a/sound/soc/intel/atom/sst/sst_acpi.c
> +++ b/sound/soc/intel/atom/sst/sst_acpi.c
> @@ -226,8 +226,8 @@ static int sst_platform_get_resources(struct intel_sst_drv *ctx)
> /* Find the IRQ */
> ctx->irq_num = platform_get_irq(pdev,
> ctx->pdata->res_info->acpi_ipc_irq_index);
> - if (ctx->irq_num <= 0)
> - return ctx->irq_num < 0 ? ctx->irq_num : -EIO;
> + if (ctx->irq_num < 0)
> + return ctx->irq_num;
>
> return 0;
> }
> --
> 2.20.1.windows.1
>
>
>


--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2021-11-30 10:49    [W:0.146 / U:1.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site