Messages in this thread Patch in this message | | | From | "Sajida Bhanu (Temp) (QUIC)" <> | Subject | RE: [PATCH V1] mtd: spi-nor: winbond: Add support for winbond chip | Date | Wed, 1 Dec 2021 04:45:42 +0000 |
| |
Hi Doug,
Sure thanks for the review.
Will address comment and share the patch .
Thanks, Sajida -----Original Message----- From: Doug Anderson <dianders@chromium.org> Sent: Wednesday, December 1, 2021 3:01 AM To: Sajida Bhanu (Temp) (QUIC) <quic_c_sbhanu@quicinc.com> Cc: tudor.ambarus@microchip.com; michael@walle.cc; p.yadav@ti.com; miquel.raynal@bootlin.com; richard@nod.at; vigneshr@ti.com; linux-mtd@lists.infradead.org; linux-kernel@vger.kernel.org; stummala@codeaurora.org; vbadigan@codeaurora.org; Ram Prakash Gupta (QUIC) <quic_rampraka@quicinc.com>; Pradeep Pragallapati (QUIC) <quic_pragalla@quicinc.com>; sartgarg@codeaurora.org Subject: Re: [PATCH V1] mtd: spi-nor: winbond: Add support for winbond chip
Hi,
On Thu, Nov 25, 2021 at 10:56 PM Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com> wrote: > > Add support for winbond W25Q512NW-IM chip. > > Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com> > --- > drivers/mtd/spi-nor/winbond.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mtd/spi-nor/winbond.c > b/drivers/mtd/spi-nor/winbond.c index 96573f6..cdfa2ee 100644 > --- a/drivers/mtd/spi-nor/winbond.c > +++ b/drivers/mtd/spi-nor/winbond.c > @@ -100,6 +100,9 @@ static const struct flash_info winbond_parts[] = { > SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, > { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024, > SECT_4K | SPI_NOR_QUAD_READ | > SPI_NOR_DUAL_READ) }, > + {"w25q512nw", INFO(0xef8020, 0, 64 * 1024, 1024, > + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | > + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) }, > { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024, > SECT_4K | SPI_NOR_DUAL_READ | > SPI_NOR_QUAD_READ) },
I have no comments on the contents of this patch, but your spacing is off. The entry above and below you have a space between the "{" and the string with the name of the flash part. You should match.
-Doug
| |