Messages in this thread Patch in this message | | | Date | Wed, 1 Dec 2021 04:39:20 +0200 | From | Laurent Pinchart <> | Subject | Re: [PATCH 2/2] media: uvcvideo: Avoid returning invalid controls |
| |
Hi Ricardo,
Thank you for the patch.
On Tue, Nov 30, 2021 at 03:50:26PM +0000, Ricardo Ribalda wrote: > If the memory where ctrl_found is places has the value of uvc_ctrl and
s/places/placed/ s/uvc_ctrl/uvc_control/
> __uvc_find_control does not find the control we will return and invalid
s/and invalid/an invalid/
> index.
The change of this happening is small, but it exists.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Fixes: 6350d6a4ed487 ("media: uvcvideo: Set error_idx during ctrl_commit errors") > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> > --- > drivers/media/usb/uvc/uvc_ctrl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c > index f7b7add3cfa59..f1f6bb14fb0a6 100644 > --- a/drivers/media/usb/uvc/uvc_ctrl.c > +++ b/drivers/media/usb/uvc/uvc_ctrl.c > @@ -1639,7 +1639,7 @@ static int uvc_ctrl_find_ctrl_idx(struct uvc_entity *entity, > struct uvc_control *uvc_control) > { > struct uvc_control_mapping *mapping = NULL; > - struct uvc_control *ctrl_found; > + struct uvc_control *ctrl_found = NULL; > unsigned int i; > > if (!entity)
-- Regards,
Laurent Pinchart
| |