Messages in this thread | | | From | Anand Ashok Dumbre <> | Subject | RE: [PATCH v11 1/5] device property: Add fwnode_iomap() | Date | Tue, 30 Nov 2021 21:58:12 +0000 |
| |
Hi Andy,
Thanks for the review.
> -----Original Message----- > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Sent: Thursday 25 November 2021 11:42 AM > To: Anand Ashok Dumbre <ANANDASH@xilinx.com> > Cc: linux-kernel@vger.kernel.org; jic23@kernel.org; lars@metafoo.de; linux- > iio@vger.kernel.org; git <git@xilinx.com>; Michal Simek > <michals@xilinx.com>; gregkh@linuxfoundation.org; rafael@kernel.org; > linux-acpi@vger.kernel.org; heikki.krogerus@linux.intel.com > Subject: Re: [PATCH v11 1/5] device property: Add fwnode_iomap() > > On Wed, Nov 24, 2021 at 10:54:03PM +0000, Anand Ashok Dumbre wrote: > > This patch introduces a new helper routine - fwnode_iomap(), which > > allows to map the memory mapped IO for a given device node. > > > > This implementation does not cover the ACPI case and may be expanded > > in the future. The main purpose here is to be able to develop resource > > provider agnostic drivers. > > ... > > > +void __iomem *fwnode_iomap(struct fwnode_handle *fwnode, int > index) { > > > + if (is_of_node(fwnode)) > > + return of_iomap(to_of_node(fwnode), index); > > It seems this part should be wrapped in some ifdeffery according to kbuild > bot report.
I see that of_iomap is wrapped in #ifdef I will fix that and send a new patch.
> > > + return NULL; > > +} > > +EXPORT_SYMBOL(fwnode_iomap); > > -- > With Best Regards, > Andy Shevchenko >
Thanks, Anand
| |