Messages in this thread | | | Date | Tue, 30 Nov 2021 12:03:30 -0800 | From | Matthias Kaehlcke <> | Subject | Re: [PATCH v2 4/4] arm64: dts: qcom: sc7280-crd: Add Touchscreen and touchpad support |
| |
On Mon, Nov 29, 2021 at 05:01:37PM +0530, Rajendra Nayak wrote: > From: Kshitiz Godara <kgodara1@codeaurora.org> > > Add Touchscreen and touchpad hid-over-i2c node for the sc7280 CRD board > > Signed-off-by: Kshitiz Godara <kgodara1@codeaurora.org> > Signed-off-by: Rajendra Nayak <quic_rjendra@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sc7280-crd.dts | 61 +++++++++++++++++++++++++++++++++ > 1 file changed, 61 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-crd.dts > index 1e3e2f3..fcfb14d 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts > +++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts > @@ -23,6 +23,47 @@ > }; > }; > > +ap_tp_i2c: &i2c0 { > + status = "okay"; > + clock-frequency = <400000>; > + > + trackpad: trackpad@15 { > + compatible = "hid-over-i2c"; > + reg = <0x15>; > + pinctrl-names = "default"; > + pinctrl-0 = <&tp_int_odl>; > + > + interrupt-parent = <&tlmm>; > + interrupts = <7 IRQ_TYPE_EDGE_FALLING>; > + > + post-power-on-delay-ms = <20>; > + hid-descr-addr = <0x0001>; > + vdd-supply = <&vreg_l18b_1p8>; > + > + wakeup-source; > + }; > +}; > + > +ap_ts_pen_1v8: &i2c13 { > + status = "okay"; > + clock-frequency = <400000>; > + > + ap_ts: touchscreen@5c { > + compatible = "hid-over-i2c"; > + reg = <0x5C>;
nit: the convention seems to be to use lowercase characters for hex numbers.
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
| |