Messages in this thread | | | Subject | Re: [PATCH v1 1/2] i2c: designware-pci: Add support for Fast Mode Plus and High Speed Mode | From | Jarkko Nikula <> | Date | Tue, 30 Nov 2021 09:51:42 +0200 |
| |
On 11/29/21 6:56 PM, Wolfram Sang wrote: > On Tue, Nov 09, 2021 at 04:05:51PM +0530, lakshmi.sowjanya.d@intel.com wrote: >> From: Lakshmi Sowjanya D <lakshmi.sowjanya.d@intel.com> >> >> Add support to configure HCNT, LCNT values for Fast Mode Plus and High >> Speed Mode. >> >> Signed-off-by: Lakshmi Sowjanya D <lakshmi.sowjanya.d@intel.com> > > Applied to for-next, thanks! > >> + u32 fp_lcnt; >> + u32 hs_lcnt; >> u32 sda_hold; > > Short question unrelated to this patch. Why are all these u32... > >> dev->ss_hcnt = cfg->ss_hcnt; >> dev->fs_hcnt = cfg->fs_hcnt; > > ... and the ones in dev are u16? Wouldn't it be easier if they all had > the same type? > True, only sda_hold(_time) is u32 and other timing parameters are u16.
Lakshmi: Would you like to send a patch fixing this and get more contributions to the driver :-)
Originally this discrepancy was introduced 2014 by the commit 8efd1e9ee3bd ("i2c: designware-pci: set ideal HCNT, LCNT and SDA hold time value").
Jarkko
| |