Messages in this thread | | | Date | Wed, 3 Nov 2021 12:45:27 -0500 | From | Bjorn Helgaas <> | Subject | Re: [PATCH v3 2/2] mwifiex: Add quirk to disable deep sleep with certain hardware revision |
| |
On Wed, Nov 03, 2021 at 07:38:35PM +0200, Andy Shevchenko wrote: > On Wed, Nov 03, 2021 at 06:10:55PM +0100, Jonas Dreßler wrote:
> > + if (mwifiex_send_cmd(priv, HostCmd_CMD_VERSION_EXT, > > + HostCmd_ACT_GEN_GET, 0, &ver_ext, false)) { > > + mwifiex_dbg(priv->adapter, MSG, > > + "Checking hardware revision failed.\n"); > > + } > > Checkpatch won't warn you if string literal even > 100. So move it to one line > and drop curly braces. Ditto for the case(s) below.
I don't understand the advantage of making this one line. I *do* understand the advantage of joining a single string so grep can find it more easily. But that does make the code a little bit uglier, and in a case like this, you don't get the benefit of better grepping, so I don't see the point.
| |