Messages in this thread | | | Date | Wed, 3 Nov 2021 10:19:21 -0700 | From | Tadeusz Struk <> | Subject | Re: [PATCH v2 1/2] scsi: scsi_ioctl: Validate command size |
| |
On 11/3/21 10:09, Christoph Hellwig wrote: >> + if (hdr->cmd_len < 6) >> + return -EMSGSIZE; > The checks looks good, but I'd be tempted to place it next to the > other check on hdr->cmd_len in the caller.
Do you mean in sg_io()? I don't mind changing it, but putting the check here in scsi_fill_sghdr_rq() was suggested by Douglas (cc'ed now).
-- Thanks, Tadeusz
| |