Messages in this thread | | | Subject | Re: [GIT PULL] Thermal control updates for v5.16-rc1 | From | Daniel Lezcano <> | Date | Wed, 3 Nov 2021 16:20:00 +0100 |
| |
On 03/11/2021 16:03, Linus Torvalds wrote: > On Wed, Nov 3, 2021 at 12:53 AM Daniel Lezcano > <daniel.lezcano@linaro.org> wrote: >> >> Is the platform with 19 thermal zones and default thermal policy set to >> userspace governor ? > > I think it has 11 thermal zones judging by > /sys/class/thermal/thermal_zone* going from 0 to 10. > > And the kernel default seems to be > > CONFIG_THERMAL_DEFAULT_GOV_STEP_WISE=y > > but presumably this is F34 then setting it to 'userspace' (the kernel > config comes from the F34 one too, although it's been tweaked for the > machine). > > I suspect I could just turn off THERMAL_GOV_USER_SPACE and get rid of > the message, that's not the issue. > > The issue is "why is the kernel spewing pointlessly the same message > over and over again?"
Yes, I agree and I will provide a patch to convert it to pr_warn_once but having 19 messages sounds like the policy was set several times and that is surprising.
This is why I asked about the configuration because the message should appear when one thermal zone is changing the policy to 'user_space' and that happens once per thermal zone, logically.
I'll send a fix for that and try to figure out what f34 is doing with the thermal governors.
Thanks
-- Daniel
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |