Messages in this thread | | | Date | Wed, 3 Nov 2021 17:28:14 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] staging: r8188eu: hal: remove goto statement and local variable |
| |
On Wed, Oct 27, 2021 at 10:08:08AM +0530, Saurav Girepunje wrote: > Remove the goto statement from FillH2CCmd_88E(). In this function goto > can be replace by return statement. As on goto label exit, function > only return it is not performing any cleanup. Avoiding goto will > improve the function readability. After replacing the goto statement > local variable ret is also not needed. So remove the ret local variable. > > Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com> > ---
Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards, dan carpenter
| |