Messages in this thread | | | Date | Wed, 3 Nov 2021 13:16:00 +0000 | From | Matthew Wilcox <> | Subject | Re: [PATCH v3 4/6] folio: Add a function to get the host inode for a folio |
| |
On Tue, Nov 02, 2021 at 08:30:46AM +0000, David Howells wrote: > Add a convenience function, folio_inode() that will get the host inode from > a folio's mapping.
I'm not opposed, but it only saves two characters, so I'm not entirely sure it justifies its existance. On the other hand, folio_inode() is clear about what it does.
> + * For folios which are in the page cache, return the inode that is hosting > + * this folio belongs to.
This looks like an editing mistake. Either you meant 'return the inode that hosts this folio' or 'return the inode this folio belongs to' (and i prefer the second).
With that grammo fixed,
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
| |